Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change appearance prop examples to not use red as primary color & use black as text color #1537

Merged
merged 4 commits into from
Sep 17, 2024

Conversation

victoriaxyz
Copy link
Contributor

@victoriaxyz victoriaxyz commented Sep 13, 2024

Important

🔎 Previews:

Explanation:

This PR:

Screenshot 2024-09-16 at 16 24 08 Screenshot 2024-09-16 at 16 24 18

@victoriaxyz victoriaxyz requested a review from a team as a code owner September 13, 2024 21:50
Copy link

Hey, here’s your docs preview: https://clerk.com/docs/pr/1537

@alexisintech
Copy link
Member

purple cannot be used - let's use blue instead.
also, there are some places where there is still colorPrimary: 'red' so make sure to update all of those instances

and make sure to test these different examples please :) I should have done it on the last PR - that's my bad too 🙈

Screenshot 2024-09-16 at 10 07 00

@alexisintech alexisintech changed the title doc-9205: change ClerkProvider text color from white to black Change appearance prop examples to not use red as primary color & use black as text color Sep 16, 2024
@victoriaxyz victoriaxyz merged commit 5b0d6cf into main Sep 17, 2024
4 checks passed
@victoriaxyz victoriaxyz deleted the vi/docs-9205/v2 branch September 17, 2024 17:26
royanger pushed a commit that referenced this pull request Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants